Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add compatibility tests for v7.6.x #6639

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Jun 19, 2024
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

"v8.2.0",
"v7.5.0",
"v7.4.0",
"v6.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need v6 tags since its EOL?

Copy link
Contributor Author

@crodriguezvega crodriguezvega Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the tags for EoL releases just to check compatibility with them. I think it makes sense that, even if those release lines are not supported anymore, that we do some basic compatibility check with the new releases that we make.

@crodriguezvega
Copy link
Contributor Author

I am going to merge this one because I want to run the compatibility tests and have still enough time to fix any issues if they arise. If somebody has post-merge comments, I will address them separately.

@crodriguezvega crodriguezvega merged commit 3f6521e into main Jun 19, 2024
78 of 80 checks passed
@crodriguezvega crodriguezvega deleted the carlos/compatibility-tests-v7.6.x branch June 19, 2024 09:38
bznein pushed a commit that referenced this pull request Jun 26, 2024
* chore: add compatibility tests for v7.6.x

* Update ica-unordered-channel.json

* Update incentivized-transfer-2.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PRs that need prompt reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants